This repository has been archived by the owner on Nov 16, 2022. It is now read-only.
Refactor to support option by value #24 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
======================================
Coverage 7.69% 7.69%
======================================
Files 3 3
Lines 13 13
======================================
Hits 1 1
Misses 12 12Continue to review full report at Codecov.
|
Open
|
|
|
I can set it to name if color is found, and on value if not. |
Sneki
approved these changes
Feb 19, 2019
|
@Sneki Please just tag and push new version of the package and try it out in Builder. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added support to get color if returnType is
value.A lot of refactoring there so please check it, I need a couple of eyes more here.
Example is in App.vue.
Fix #24